Re: [PATCH 1/3] gpio: Add new flags to control sleep status of GPIOs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On Tue, May 16, 2017 at 5:31 PM, Charles Keepax
<ckeepax@xxxxxxxxxxxxxxxxxxxxxxxxxxx> wrote:

> Add new flags to allow users to specify that they are not concerned with
> the status of GPIOs whilst in a sleep/low power state.
>
> Signed-off-by: Charles Keepax <ckeepax@xxxxxxxxxxxxxxxxxxxxxxxxxxx>

Would be nice to have some opinion from the DT maintainers about
this but seems all right to me.

> +++ b/include/dt-bindings/gpio/gpio.h
> @@ -21,6 +21,10 @@
>  #define GPIO_LINE_OPEN_SOURCE 0
>  #define GPIO_LINE_OPEN_DRAIN 4
>
> +/* Bit 3 express GPIO suspend/resume persistence */
> +#define GPIO_SLEEP_MAINTAIN_VALUE 0
> +#define GPIO_SLEEP_MAY_LOOSE_VALUE 8
> +
>  /*
>   * Open Drain/Collector is the combination of single-ended open drain interface.
>   * Open Source/Emitter is the combination of single-ended open source interface.

Please move the define below the comment and macros below it,
that is using the defines right above...

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]
  Powered by Linux