> > For more information see: > > - http://linux-sunxi.org/Orange_Pi_Zero#SPI_NOR_flash > > Same remark here than on the first patch Ok, I will provide a more detailed commit message w/o external references. > > +&spi0 { > > + status = "okay"; > > + > > + flash@0 { > > + #address-cells = <1>; > > + #size-cells = <1>; > > + compatible = "mxicy,mx25l1606e", "winbond,w25q128"; > > + reg = <0>; > > + spi-max-frequency = <40000000>; > > How do the other OPi Zero that doesn't have that SPI flash behave? Hmmm. Good point. According to linux-sunxi.org docs SPI NOR flash was optional in the first production batch in Dec 2016. In later batches flash chip was pre-populated. However there are should be quite a few boards around which do not have flash. Does it make sense to set status to 'disabled' by default adding appropriate comment in the commit message ? > > + > > + partition@00000000 { > > + reg = <0x00000000 0x200000>; /* 2Mb */ > > + }; > > There's no need to create a first partition, this needs to be > user-defined. Ok, than it probably makes sense to drop it from dts. User-defined list of partitions can be passed via kernel command line. Thanks, Sergey -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
