On 5/21/2017 4:19 PM, Andreas Färber wrote:
Hi,
Am 16.05.2017 um 21:56 schrieb Martin Blumenstingl:
On Tue, May 16, 2017 at 12:05 AM, Arend Van Spriel
<arend.vanspriel@xxxxxxxxxxxx> wrote:
On 15-5-2017 22:13, Martin Blumenstingl wrote:
The example in the BCM43xx documentation uses "brcmf" as node name.
However, wireless devices should be named "wifi" instead. Fix this to
Since when is that a rule. I never got the memo and the DTC did not ever
complain to me about the naming.
How do you expect it to? Maintain a blacklist of every device model
someone might use, including all typo variations?
Not really why I was asking it. Just saying the node name is trivial as
I don't think there is different kernel behaviour depending on the node
name.
That being said I do not really care
and I suppose it is for the sake of consistency only.
I'm not sure if it's actually a rule or (as you already noted) just
for consistency. back when I added devicetree support to ath9k Rob
pointed out that the node should be named "wifi" (instead of "ath9k"),
see [0]
The general rule is that the node name should be the type of the device,
not duplicate its compatible string.
For consistency Rob was asking we use "wifi" as node name.
Fine with that. Not sure how long ago it was that I added this binding,
but DT folks were involved back than. I never looked back so I should
not be surprised with new consistency rules. I was just curious about
the story behind it.
Thanks,
Arend
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
