> -----Original Message----- > From: Shawn Guo [mailto:shawnguo@xxxxxxxxxx] > Sent: Sunday, May 21, 2017 5:31 PM > To: A.S. Dong > Cc: linux-gpio@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; > linus.walleij@xxxxxxxxxx; stefan@xxxxxxxx; Jacky Bai; Andy Duan; > kernel@xxxxxxxxxxxxxx; Rob Herring; Mark Rutland; > devicetree@xxxxxxxxxxxxxxx > Subject: Re: [PATCH V2 4/5] dt-bindings: pinctrl: add imx7ulp pinctrl > binding doc > > On Fri, May 19, 2017 at 03:05:44PM +0800, Dong Aisheng wrote: > > i.MX 7ULP has three IOMUXC instances: IOMUXC0 for M4 ports, > > IOMUXC1 for A7 ports and IOMUXC DDR for DDR interface. > > > > This patch adds the IOMUXC1 support for A7. > > > > Cc: Rob Herring <robh+dt@xxxxxxxxxx> > > Cc: Mark Rutland <mark.rutland@xxxxxxx> > > Cc: devicetree@xxxxxxxxxxxxxxx > > Cc: Linus Walleij <linus.walleij@xxxxxxxxxx> > > Cc: Shawn Guo <shawnguo@xxxxxxxxxx> > > Signed-off-by: Dong Aisheng <aisheng.dong@xxxxxxx> > > > > --- > > ChangeLog: > > v1->v2: > > * add more descriptions in binding doc > > * add missed prefix for private properties. > > * move dt-bindings/pinctrl/imx7ulp-pinfunc.h to arch/arm/boot/dts > > --- > > .../bindings/pinctrl/fsl,imx7ulp-pinctrl.txt | 63 +++ > > arch/arm/boot/dts/imx7ulp-pinfunc.h | 468 > +++++++++++++++++++++ > > Rather than being part of bindings doc patch, this pinfunc header should > be included in dts patches that add imx7ulp SoC support. > Okay. One question is that imx7ulp-pinfunc.h is mentioned in this binding doc, that means after this patch applied, users still can't see it if separate, Should we worry about this issue or not? + Refer to imx7ulp-pinfunc.h in in device tree source folder for all + available imx7ulp PIN_FUNC_ID. Last, thx for other ACKs. Regards Dong Aisheng > Shawn > > > 2 files changed, 531 insertions(+) > > create mode 100644 > > Documentation/devicetree/bindings/pinctrl/fsl,imx7ulp-pinctrl.txt > > create mode 100644 arch/arm/boot/dts/imx7ulp-pinfunc.h -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html