On Wed, Jan 08, 2014 at 12:37:03PM -0600, Rob Herring wrote:
> > Patch to parse this compatible string to follow if this binding is
> > acceptable.
>
> One minor comment below, otherwise:
>
> Acked-by: Rob Herring <robh@xxxxxxxxxx>
K, I'll send a series hopefully in a few weeks after some travel.
> > + If the phy's identifier is known then the list may contain an entry
> > + of the form: "ethernet-phy-idAAAA,BBBB" where
>
> I think this should be a period rather than a comma as we are not
> separating a vendor ID from product ID.
OK, that makes sense.
Inspecting further, the format of the 32 bit AAAABBBB is actually
broken out into:
OUI[3:18] || OUI[19:24] || MODEL[5:0] || REV[3:0]
So a possible choice with the 'vendor ID,product ID' split is:
ethernet-phyOOOOO,MM.R
xlate is:
AAAABBBB = ((OOOOO >> 6) << 16) |
((OOOOO & 0x3f) << 10) |
(MM << 4) |
R
Which doesn't textually match the register value, or any other
phy ID constants in the kernel, however makes more sense from the
'vendor ID,product ID' angle.
Eg a Marvell 88E1310 would encode into the two options as:
ethernet-phy05043,29.0
ethernet-phy-id0141.0e90
And the kernel has constants like this:
include/linux/marvell_phy.h:#define MARVELL_PHY_ID_88E1318S 0x01410e90
In light of this detail do you still like 'ethernet-phy-id0141.0e90' ?
Thanks,
Jason
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
