On Wed, Jan 08, 2014 at 07:26:06PM +0000, Sudeep Holla wrote: > From: Sudeep Holla <sudeep.holla@xxxxxxx> > +#define define_one_ro(_name) \ > +static struct cache_attr _name = \ > + __ATTR(_name, 0444, show_##_name, NULL) In the future, we do have __ATTR_RO(), which should be used instead. You should never use __ATTR() on it's own, if at all possible. I'm sweeping the tree for all usages and fixing them slowly up over time. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html