On Tue, May 9, 2017 at 4:23 PM, Rob Herring <robh+dt@xxxxxxxxxx> wrote: > On Mon, May 8, 2017 at 4:41 PM, Linus Walleij <linus.walleij@xxxxxxxxxx> wrote: >> On Mon, May 8, 2017 at 11:24 PM, Rob Herring <robh+dt@xxxxxxxxxx> wrote: >> >>>> +Example: >>>> + >>>> +syscon: syscon@40000000 { >>>> + compatible = "cortina,gemini-syscon", "cortina,gemini-clock-controller", >>>> + "syscon", "simple-mfd"; >>> >>> There are no child nodes, so you don't need simple-mfd. >> >> The example is taken from an actual device tree (look below), >> where there are child nodes, I can trim it down. >> >>>> + reg = <0x40000000 0x1000>; >>> >>> Looks like you have 2 nodes pointing to the same address with your >>> reset binding? You shouldn't have overlapping resources. It's allowed >>> for historical reasons but breaks resource creation in Linux. >> >> No... they are all in the same node, just sharing the same >> resource by way of regmap (syscon). > > Okay, then please document at least the parent syscon node in a single > doc. Splitting it is very confusing. I'm sorry. :( I'll patch the document in arm/gemini.txt where the syscon node is documented, with a single patch adding both clock and reset bindings. >> syscon: syscon@40000000 { >> compatible = "cortina,gemini-syscon", >> "cortina,gemini-clock-controller", >> "cortina,gemini-reset", > > This mostly looks fine, but you shouldn't need 3 compatible strings > for the block. OK I'll see if I can make it work with just "cortina,gemini-syscon" and skip the two others. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html