On Fri, May 05, 2017 at 03:01:04AM +0000, Y.B. Lu wrote: > Hi Shawn, > > > > -----Original Message----- > > From: Shawn Guo [mailto:shawnguo@xxxxxxxxxx] > > Sent: Friday, May 05, 2017 10:37 AM > > To: Y.B. Lu > > Cc: devicetree@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; > > ulf.hansson@xxxxxxxxxx; Rob Herring; Catalin Marinas; Harninder Rai; > > Xiaobo Xie > > Subject: Re: [v2, 1/5] mmc: dt: add compatible into eSDHC required > > properties > > > > On Thu, May 04, 2017 at 06:48:56PM +0800, Yangbo Lu wrote: > > > This patch is to add compatible into eSDHC required properties. > > > > > > Signed-off-by: Yangbo Lu <yangbo.lu@xxxxxxx> > > > --- > > > Changes for v2: > > > - Added this patch. > > > --- > > > Documentation/devicetree/bindings/mmc/fsl-esdhc.txt | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/Documentation/devicetree/bindings/mmc/fsl-esdhc.txt > > > b/Documentation/devicetree/bindings/mmc/fsl-esdhc.txt > > > index dedfb02..b04b248 100644 > > > --- a/Documentation/devicetree/bindings/mmc/fsl-esdhc.txt > > > +++ b/Documentation/devicetree/bindings/mmc/fsl-esdhc.txt > > > @@ -7,6 +7,7 @@ This file documents differences between the core > > > properties described by mmc.txt and the properties used by the sdhci- > > esdhc driver. > > > > > > Required properties: > > > + - compatible : should be "fsl,esdhc", or "fsl,<chip>-esdhc". > > > > I think either supported <chip> or the compatible should be listed > > explicitly. > > > > [Lu Yangbo-B47093] I think the reason we use <chip> is to avoid listing too much chips, and to avoid doc updating if new chips are added. > The checkpatch script also had considered that. > > Currently there're about 20 platforms with "fsl,<chip>-esdhc" compatible in kernel dts. Yes, but it's generally preferred to list possible values of <chip>. Rob -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
