On Fri, Apr 28, 2017 at 8:24 PM, Rob Herring <robh@xxxxxxxxxx> wrote: > On Mon, Apr 24, 2017 at 08:55:45PM +0200, Linus Walleij wrote: >> This adds device tree bindings and a header for the Gemini SoC >> Clock Controller. (...) >> +- compatible : shall contain the following: >> + "cortina,gemini-clock-controller" >> +- #clock-cells should be <1> (...) >> +Example: >> + >> +syscon: syscon@40000000 { >> + compatible = "cortina,gemini-syscon", "syscon", "simple-mfd"; >> + reg = <0x40000000 0x1000>; >> + >> + clock-controller { >> + compatible = "cortina,gemini-clock-controller"; >> + #clock-cells = <1>; > > There's not really much reason to have a child node here. The parent can > be the clock provider. But I should still keep the special clock controller compatible-string? I guess it is also possible to just bind all the drivers to "cortina,gemini-syscon". Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html