Hi Ramesh, Looks good. I replied to patch 3/7 requesting a small change, but otherwise I'm OK. The only thing missing is an Ack from Rob for patch 6/7 (R-car DRIF bindings). Once I have that + an updated patch 3/7 I can make a pull request for this. Regards, Hans On 05/02/17 15:26, Ramesh Shanmugasundaram wrote: > Hi Media, DT maintainers, All, > > This patch set contains two drivers > - Renesas R-Car Digital Radio Interface (DRIF) driver > - Maxim's MAX2175 RF to Bits tuner driver > > These patches were based on top of media-next repo > commit:6d95b3f24881c0fd0f345eca959a2a803a040930 > > These two drivers combined together expose a V4L2 SDR device that is compliant with the V4L2 framework [1]. Agreed review comments are incorporated in this series. > > The rcar_drif device is modelled using "renesas,bonding" property. The discussion on this property is available here [2]. > > Change history: > > v3 -> v4: > - Added ACKs > rcar_drif: > - Incorporated a number of review comments from Laurent on DRIF driver. > - Addressed comments from Rob and Laurent on bindings. > max2175: > - Minor changes addressing Hans and Laurent's comments > > v2 -> v3: > rcar_drif: > - Reduced DRIF DT properties to expose tested I2S mode only (Hans - discussion on #v4l) > - Fixed error path clean up of ctrl_hdl on rcar_drif > > v1 -> v2: > - SDR formats renamed as "planar" instead of sliced (Hans) > - Documentation formatting correction (Laurent) > > rcar_drif: > - DT model using "bonding" property > - Addressed Laurent's coments on bindings - DT optional parameters rename & rework > - Addressed Han's comments on driver > - Addressed Geert's comments on DT > > max2175: > - Avoided scaling using method proposed by Antti. Thanks > - Bindings is a separate patch (Rob) > - Addressed Rob's comment on bindings > - Added Custom controls documentation (Laurent) > > [1] v4l2-compliance report: > root@salvator-x:~# v4l2-compliance -S /dev/swradio0 > v4l2-compliance SHA : b514d615166bdc0901a4c71261b87db31e89f464 > > Driver Info: > Driver name : rcar_drif > Card type : R-Car DRIF > Bus info : platform:R-Car DRIF > Driver version: 4.11.0 > Capabilities : 0x85310000 > SDR Capture > Tuner > Read/Write > Streaming > Extended Pix Format > Device Capabilities > Device Caps : 0x05310000 > SDR Capture > Tuner > Read/Write > Streaming > Extended Pix Format > > Compliance test for device /dev/swradio0 (not using libv4l2): > > Required ioctls: > test VIDIOC_QUERYCAP: OK > > Allow for multiple opens: > test second sdr open: OK > test VIDIOC_QUERYCAP: OK > test VIDIOC_G/S_PRIORITY: OK > test for unlimited opens: OK > > Debug ioctls: > test VIDIOC_DBG_G/S_REGISTER: OK > test VIDIOC_LOG_STATUS: OK > > Input ioctls: > test VIDIOC_G/S_TUNER/ENUM_FREQ_BANDS: OK > test VIDIOC_G/S_FREQUENCY: OK > test VIDIOC_S_HW_FREQ_SEEK: OK (Not Supported) > test VIDIOC_ENUMAUDIO: OK (Not Supported) > test VIDIOC_G/S/ENUMINPUT: OK (Not Supported) > test VIDIOC_G/S_AUDIO: OK (Not Supported) > Inputs: 0 Audio Inputs: 0 Tuners: 1 > > Output ioctls: > test VIDIOC_G/S_MODULATOR: OK (Not Supported) > test VIDIOC_G/S_FREQUENCY: OK > test VIDIOC_ENUMAUDOUT: OK (Not Supported) > test VIDIOC_G/S/ENUMOUTPUT: OK (Not Supported) > test VIDIOC_G/S_AUDOUT: OK (Not Supported) > Outputs: 0 Audio Outputs: 0 Modulators: 0 > > Input/Output configuration ioctls: > test VIDIOC_ENUM/G/S/QUERY_STD: OK (Not Supported) > test VIDIOC_ENUM/G/S/QUERY_DV_TIMINGS: OK (Not Supported) > test VIDIOC_DV_TIMINGS_CAP: OK (Not Supported) > test VIDIOC_G/S_EDID: OK (Not Supported) > > Control ioctls: > test VIDIOC_QUERY_EXT_CTRL/QUERYMENU: OK > test VIDIOC_QUERYCTRL: OK > test VIDIOC_G/S_CTRL: OK > test VIDIOC_G/S/TRY_EXT_CTRLS: OK > test VIDIOC_(UN)SUBSCRIBE_EVENT/DQEVENT: OK > test VIDIOC_G/S_JPEGCOMP: OK (Not Supported) > Standard Controls: 5 Private Controls: 3 > > Format ioctls: > test VIDIOC_ENUM_FMT/FRAMESIZES/FRAMEINTERVALS: OK > test VIDIOC_G/S_PARM: OK (Not Supported) > test VIDIOC_G_FBUF: OK (Not Supported) > test VIDIOC_G_FMT: OK > test VIDIOC_TRY_FMT: OK > test VIDIOC_S_FMT: OK > test VIDIOC_G_SLICED_VBI_CAP: OK (Not Supported) > test Cropping: OK (Not Supported) > test Composing: OK (Not Supported) > test Scaling: OK (Not Supported) > > Codec ioctls: > test VIDIOC_(TRY_)ENCODER_CMD: OK (Not Supported) > test VIDIOC_G_ENC_INDEX: OK (Not Supported) > test VIDIOC_(TRY_)DECODER_CMD: OK (Not Supported) > > Buffer ioctls: > test VIDIOC_REQBUFS/CREATE_BUFS/QUERYBUF: OK > test VIDIOC_EXPBUF: OK (Not Supported) > > Test input 0: > > > Total: 43, Succeeded: 43, Failed: 0, Warnings: 0 > root@salvator-x:~# > > [2] "bonding" DT property discussion (https://www.mail-archive.com/linux-renesas-soc@xxxxxxxxxxxxxxx/msg09415.html) > > Ramesh Shanmugasundaram (7): > media: v4l2-ctrls: Reserve controls for MAX217X > dt-bindings: media: Add MAX2175 binding description > media: i2c: max2175: Add MAX2175 support > media: Add new SDR formats PC16, PC18 & PC20 > doc_rst: media: New SDR formats PC16, PC18 & PC20 > dt-bindings: media: Add Renesas R-Car DRIF binding > media: platform: rcar_drif: Add DRIF support > > .../devicetree/bindings/media/i2c/max2175.txt | 61 + > .../devicetree/bindings/media/renesas,drif.txt | 187 +++ > .../devicetree/bindings/property-units.txt | 1 + > .../media/uapi/v4l/pixfmt-sdr-pcu16be.rst | 55 + > .../media/uapi/v4l/pixfmt-sdr-pcu18be.rst | 55 + > .../media/uapi/v4l/pixfmt-sdr-pcu20be.rst | 54 + > Documentation/media/uapi/v4l/sdr-formats.rst | 3 + > Documentation/media/v4l-drivers/index.rst | 1 + > Documentation/media/v4l-drivers/max2175.rst | 60 + > drivers/media/i2c/Kconfig | 4 + > drivers/media/i2c/Makefile | 2 + > drivers/media/i2c/max2175/Kconfig | 8 + > drivers/media/i2c/max2175/Makefile | 4 + > drivers/media/i2c/max2175/max2175.c | 1437 +++++++++++++++++++ > drivers/media/i2c/max2175/max2175.h | 108 ++ > drivers/media/platform/Kconfig | 25 + > drivers/media/platform/Makefile | 1 + > drivers/media/platform/rcar_drif.c | 1488 ++++++++++++++++++++ > drivers/media/v4l2-core/v4l2-ioctl.c | 3 + > include/uapi/linux/v4l2-controls.h | 5 + > include/uapi/linux/videodev2.h | 3 + > 21 files changed, 3565 insertions(+) > create mode 100644 Documentation/devicetree/bindings/media/i2c/max2175.txt > create mode 100644 Documentation/devicetree/bindings/media/renesas,drif.txt > create mode 100644 Documentation/media/uapi/v4l/pixfmt-sdr-pcu16be.rst > create mode 100644 Documentation/media/uapi/v4l/pixfmt-sdr-pcu18be.rst > create mode 100644 Documentation/media/uapi/v4l/pixfmt-sdr-pcu20be.rst > create mode 100644 Documentation/media/v4l-drivers/max2175.rst > create mode 100644 drivers/media/i2c/max2175/Kconfig > create mode 100644 drivers/media/i2c/max2175/Makefile > create mode 100644 drivers/media/i2c/max2175/max2175.c > create mode 100644 drivers/media/i2c/max2175/max2175.h > create mode 100644 drivers/media/platform/rcar_drif.c > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
