Re: [RFC 3/3] dt: bindings: Add a binding for referencing EEPROM from camera sensors

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On Thu, May 04, 2017 at 04:38:04PM +0200, Sebastian Reichel wrote:
> Hi,
> 
> On Tue, May 02, 2017 at 01:25:49PM +0300, Sakari Ailus wrote:
> > Many camera sensor devices contain EEPROM chips that describe the
> > properties of a given unit --- the data is specific to a given unit can
> > thus is not stored e.g. in user space or the driver.
> > 
> > Some sensors embed the EEPROM chip and it can be accessed through the
> > sensor's I²C interface. This property is to be used for devices where the
> > EEPROM chip is accessed through a different I²C address than the sensor.
> > 
> > The intent is to later provide this information to the user space.
> > 
> > Signed-off-by: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx>
> > ---
> >  Documentation/devicetree/bindings/media/video-interfaces.txt | 3 +++
> >  1 file changed, 3 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/media/video-interfaces.txt b/Documentation/devicetree/bindings/media/video-interfaces.txt
> > index e52aefc..9bd2005 100644
> > --- a/Documentation/devicetree/bindings/media/video-interfaces.txt
> > +++ b/Documentation/devicetree/bindings/media/video-interfaces.txt
> > @@ -80,6 +80,9 @@ Optional properties
> >  - lens-focus: A phandle to the node of the lens. Only valid for device
> >    nodes that are related to an image sensor.
> >  
> > +- eeprom: A phandle to the node of the related EEPROM. Only valid for
> > +  device nodes that are related to an image sensor.
> 
> Here it's even more obvious, that the second sentence is redundant.
> The requirement is already in the first sentence :) Instead it
> should be mentioned, that this is to be used by devices not having
> their own embedded eeprom. How about:
> 
> eeprom: A phandle to the node of the EEPROM describing the camera
> sensor (i.e. device specific calibration data), in case it differs
> from the sensor node.

Ack. I addressed the rest of the feedback, too, and posted RFC v2.

-- 
Sakari Ailus
e-mail: sakari.ailus@xxxxxx	XMPP: sailus@xxxxxxxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]
  Powered by Linux