Hi, On Fri, May 05, 2017 at 11:28:34AM +0300, Sakari Ailus wrote: > Sebastian Reichel wrote: > > On Tue, May 02, 2017 at 01:25:47PM +0300, Sakari Ailus wrote: > > > +- flash: An array of phandles that refer to the flash light sources > > > + related to an image sensor. These could be e.g. LEDs. In case the LED > > > + driver drives more than a single LED, then the phandles here refer to > > > + the child nodes of the LED driver describing individual LEDs. Only > > > + valid for device nodes that are related to an image sensor. > > > > s/driver/controller/g - DT describes HW. Otherwise > > Driver is hardware in this case. :-) The chip that acts as a current sink or > source for the LED is the driver. E.g. the adp1653 documentation describes > the chip as "Compact, High Efficiency, High Power, Flash/Torch LED Driver > with Dual Interface". > > It might be still possible to improve the wording. Software oriented folks > are more likely to misunderstand the meaning of driver here, but controller > might seem ambiguous for hardware oriented people. > > How about: > > - flash: An array of phandles that refer to the flash light sources > related to an image sensor. These could be e.g. LEDs. In case the LED > driver (current sink or source chip for the LED(s)) drives more than a > single LED, then the phandles here refer to the child nodes of the LED > driver describing individual LEDs. Only valid for device nodes that are > related to an image sensor. Maybe drop the last sentence? The requirement is already in the first one. Otherwise: Reviewed-by: Sebastian Reichel <sebastian.reichel@xxxxxxxxxxxxxxx> -- Sebastian
Attachment:
signature.asc
Description: PGP signature
