于 2017年5月4日 GMT+08:00 下午10:04:31, Maxime Ripard <maxime.ripard@xxxxxxxxxxxxxxxxxx> 写到: >On Thu, May 04, 2017 at 09:49:58PM +0800, Icenowy Zheng wrote: >> Allwinner A10, A20 and R40 SoCs have similar GPIO layout. >> >> Add SoC definitions in pinctrl-sunxi.h, in order to merge A20 support >> into A10 driver, and add R40 support into it. > >While your commit log is good, the commit title is misleading since >you're not adding it to the A10 driver. You just adding SoC IDs >definitions Is "pinctrl: sunxi: Add SoC ID definitions for A10, A20 and R40 SoCs" OK? > >Maxime -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html