Hi Andi, Quick question: On Mon, Mar 27, 2017 at 10:07:43PM +0900, Andi Shyti wrote: > +static irqreturn_t stmfts_irq_handler(int irq, void *dev) > +{ > + struct stmfts_data *sdata = dev; > + int ret; > + > + mutex_lock(&sdata->mutex); > + ret = i2c_smbus_read_i2c_block_data(sdata->client, > + STMFTS_READ_ONE_EVENT, > + STMFTS_EVENT_SIZE, sdata->data); > + > + if (ret < 0 || ret != STMFTS_EVENT_SIZE) > + goto exit; Why do we split read into 2 chunks? Can we issue STMFTS_READ_ALL_EVENT right away instead of reading first event, analyzing it, and then (maybe) fetching the rest? Also, why do we use smbus protocol for the first event and i2c for the rest? Thanks. -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html