On 2017-04-21 16:18, Philipp Zabel wrote: > Hi Peter, > > On Thu, 2017-04-13 at 18:43 +0200, Peter Rosin wrote: > [...] >> +int mux_control_select(struct mux_control *mux, int state) > > state could be unsigned int for the consumer facing API. > >> +{ >> + int ret; > > And mux_control_select should check that (0 <= state < mux->states). Yes, that makes sense. I worried that we might end up with signed/unsigned comparisons since the internal state still needs to be signed, but that didn't happen when I tried... I'll include this change in v14. Cheers, peda -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html