Got them, thanks! Sent from my iPad 在 2014-1-7,21:52,"Shawn Guo" <shawn.guo@xxxxxxxxxx> 写道: > On Mon, Jan 06, 2014 at 03:57:37PM -0500, Anson Huang wrote: >> Add ocram driver support on i.MX6SL. > > s/driver/device, both commit log and patch subject. > >> >> Signed-off-by: Anson Huang <b20788@xxxxxxxxxxxxx> >> --- >> arch/arm/boot/dts/imx6sl.dtsi | 6 ++++++ >> 1 file changed, 6 insertions(+) >> >> diff --git a/arch/arm/boot/dts/imx6sl.dtsi b/arch/arm/boot/dts/imx6sl.dtsi >> index b526118..575e222 100644 >> --- a/arch/arm/boot/dts/imx6sl.dtsi >> +++ b/arch/arm/boot/dts/imx6sl.dtsi >> @@ -532,6 +532,12 @@ >> interrupts = <0 57 IRQ_TYPE_LEVEL_HIGH>; >> }; >> >> + ocram: sram@00900000 { >> + compatible = "mmio-sram"; >> + reg = <0x00900000 0x20000>; >> + clocks = <&clks IMX6SL_CLK_OCRAM>; >> + }; >> + > > When a node is named in form of name@num, we should sort the node in num > order. That said, the node should be added before l2-cache@00a02000 > rather than here. > > I fixed them all up, and applied the patch. > > Shawn > >> src: src@020d8000 { >> compatible = "fsl,imx6sl-src", "fsl,imx51-src"; >> reg = <0x020d8000 0x4000>; >> -- >> 1.7.9.5 >> >> > ?韬{.n?????%??檩??w?{.n????z谵{???塄}?财??j:+v??????2??璀??摺?囤??z夸z罐?+?????w棹f