On Thu, Apr 20, 2017 at 10:56:34AM -0500, Rob Herring wrote:
> On Mon, Apr 17, 2017 at 03:40:10PM -0700, Moritz Fischer wrote:
> > Introduce a device tree binding for specifying the trickle charger
> > configuration for ds1374. This is based on the code for ds13390.
> >
> > Signed-off-by: Moritz Fischer <mdf@xxxxxxxxxx>
> > ---
> > .../devicetree/bindings/rtc/dallas,ds1374.txt | 18 ++++++++
> > drivers/rtc/rtc-ds1374.c | 54 ++++++++++++++++++++++
> > 2 files changed, 72 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/rtc/dallas,ds1374.txt
> >
> > diff --git a/Documentation/devicetree/bindings/rtc/dallas,ds1374.txt b/Documentation/devicetree/bindings/rtc/dallas,ds1374.txt
> > new file mode 100644
> > index 0000000..4cf5bd7
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/rtc/dallas,ds1374.txt
> > @@ -0,0 +1,18 @@
> > +* Dallas DS1374 I2C Real-Time Clock / WDT
>
> Please remove from trivial-devices.txt, too. (which is moving in 4.12
> BTW)
Ok, I'll redo this on top of b7e252fcddfa573bb1ee275b53bba6cef85671d4
(Documentation: devicetree: move trivial-devices out of I2C realm) then.
>
> > +
> > +Required properties:
> > +- compatible: Should contain "dallas,ds1374".
> > +- reg: I2C address for chip
> > +
> > +Optional properties:
> > +- trickle-resistor-ohms : Selected resistor for trickle charger
> > + Values usable for ds1374 are 250, 2000, 4000
> > + Should be given if trickle charger should be enabled
> > +- trickle-diode-disable : Do not use internal trickle charger diode
> > + Should be given if internal trickle charger diode should be disabled
>
> These should have vendor prefix unless you think they are common.
Well works at least for maxim, dallas & different models like
ds1390, ds1374, so I figured I'd keep the bindings the same.
>
> > +Example:
> > + ds1374: rtc@0 {
> > + compatible = "dallas,ds1374";
> > + trickle-resistor-ohms = <250>;
> > + reg = <0>;
> > + };
Thanks,
Moritz
Attachment:
signature.asc
Description: PGP signature
