Re: [PATCH v5 5/8] i2c: i2c-cbus-gpio: Add vendor prefix to retu node in example

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




Hello Wolfram,

On 04/19/2017 02:51 PM, Wolfram Sang wrote:
> On Wed, Apr 12, 2017 at 02:27:56PM -0300, Javier Martinez Canillas wrote:
>> The example contains a device node for a retu device, but
>> its compatible string doesn't have a vendor prefix.
>>
>> While being there, drop the -mfd suffix since isn't correct.
>>
>> Signed-off-by: Javier Martinez Canillas <javier@xxxxxxxxxxxxxxx>
>> Acked-by: Rob Herring <robh@xxxxxxxxxx>
>> Acked-by: Aaro Koskinen <aaro.koskinen@xxxxxx>
>> Acked-by: Tony Lindgren <tony@xxxxxxxxxxx>
> 
> Wouldn't it be nice if we fix the driver also so it actually matches the
> below compatible? I can't find such a change in linux-next.
> 

[snip]

>>  
>> -	retu-mfd: retu@1 {
>> -		compatible = "retu-mfd";
>> +	retu: retu@1 {
>> +		compatible = "nokia,retu";
>>  		reg = <0x1>;
>>  	};

You mean having a "nokia,retu" entry in a OF table?

That's done by patch 3/8 in this series:

http://www.spinics.net/lists/devicetree/msg173145.html

Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]
  Powered by Linux