> -----Original Message----- > From: Huang Shijie [mailto:b32955@xxxxxxxxxxxxx] > Sent: Tuesday, January 07, 2014 3:52 PM > To: Shawn Guo > Cc: Lu Jingchang-B35083; devicetree@xxxxxxxxxxxxxxx; linux-arm- > kernel@xxxxxxxxxxxxxxxxxxx > Subject: Re: [PATCH] ARM: dts: vf610: use the interrupt macros > > On Mon, Jan 06, 2014 at 02:04:33PM +0800, Shawn Guo wrote: > > On Wed, Dec 25, 2013 at 02:19:27PM +0800, Huang Shijie wrote: > > > This patch uses the IRQ_TYPE_LEVEL_HIGH/IRQ_TYPE_NONE to replace > > > the hardcode. > > > > > > Signed-off-by: Huang Shijie <b32955@xxxxxxxxxxxxx> > > > --- > > > arch/arm/boot/dts/vf610.dtsi | 37 +++++++++++++++++++------------- > ----- > > > 1 files changed, 19 insertions(+), 18 deletions(-) > > > > > > diff --git a/arch/arm/boot/dts/vf610.dtsi > b/arch/arm/boot/dts/vf610.dtsi > > > index ef8a0ee..cd5bb86 100644 > > > --- a/arch/arm/boot/dts/vf610.dtsi > > > +++ b/arch/arm/boot/dts/vf610.dtsi > > > @@ -10,6 +10,7 @@ > > > #include "skeleton.dtsi" > > > #include "vf610-pingrp.h" > > > #include <dt-bindings/clock/vf610-clock.h> > > > +#include <dt-bindings/interrupt-controller/irq.h> > > > > > > / { > > > aliases { > > > @@ -90,7 +91,7 @@ > > > uart0: serial@40027000 { > > > compatible = "fsl,vf610-lpuart"; > > > reg = <0x40027000 0x1000>; > > > - interrupts = <0 61 0x00>; > > > > Why is it so special having a 0x00 IRQ trigger type? Or is it just a > > typo? While we are at it, we should probably fix it if it's a typo. > hi Jingchang: > i think it is a typo. > > do you any idea about it? Yes, it is a typo I made, please help fix it here. Thanks! Jingchang > > thanks > Huang Shijie > > > > Shawn > > > > > + interrupts = <0 61 IRQ_TYPE_NONE>; > > > clocks = <&clks VF610_CLK_UART0>; > > > clock-names = "ipg"; > > > status = "disabled"; > > > @@ -99,7 +100,7 @@ > > > uart1: serial@40028000 { > > > compatible = "fsl,vf610-lpuart"; > > > reg = <0x40028000 0x1000>; > > > - interrupts = <0 62 0x04>; > > > + interrupts = <0 62 IRQ_TYPE_LEVEL_HIGH>; > > > clocks = <&clks VF610_CLK_UART1>; > > > clock-names = "ipg"; > > > status = "disabled"; ��.n��������+%������w��{.n����z�{��ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f
