Hello Alexandre, On 04/13/2017 06:20 PM, Alexandre Belloni wrote: > On 13/04/2017 at 18:09:56 -0300, Javier Martinez Canillas wrote: >> Hello Peter, >> >> On 04/13/2017 05:43 PM, Peter Rosin wrote: >>> On 2017-04-13 20:28, Javier Martinez Canillas wrote: >> >> [snip] >> >>>> >>>> eeprom@50 { >>>> - compatible = "nxp,24c02"; >>>> + compatible = "nxp,24c02","atmel,24c02"; >>>> reg = <0x50>; >>>> pagesize = <16>; >>>> }; >>>> >>> >>> Sure, in principle. But not having a space after the commas is a real OCD >>> trigger for me. My spine is rotating... :-) >>> >> >> Right, Geert already pointed out. It's something I missed in my sed script >> so I got it wrong in all the DTS :( >> >> I'll fix my script and send a v2. >> > > That would be v3, right? ;) > err, right :) >>> Anyway, with those whitespace fixes (and without them too, but please): >>> Acked-by: Peter Rosin <peda@xxxxxxxxxx> >>> >> >> Thanks for the review! >> > > I'd like to be copied on the first patches to ensure they are applied > before applying that one. (Also, it is probably too late for 4.12 anyway Ok, I'll copy you on the whole patch-set. But keep in mind that there is no strict order since $SUBJECT without the at24 OF table is a no-op (the match happens between first device in compatible string and I2C table). > because we are past rc6). > Yes, there's no rush on applying these. I'm just posting all the patches needed to finally have a proper OF modalias reporting in the I2C core. Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html