On Thu, Apr 13, 2017 at 3:25 PM, Alan Tull <atull@xxxxxxxxxx> wrote: > On Thu, Apr 13, 2017 at 3:07 PM, Rob Herring <robh@xxxxxxxxxx> wrote: >> On Sun, Apr 09, 2017 at 10:10:31AM -0700, Moritz Fischer wrote: >>> This adds the binding documentation for the Xilinx LogiCORE PR >>> Decoupler soft core. >>> >>> Signed-off-by: Moritz Fischer <mdf@xxxxxxxxxx> >>> Signed-off-by: Michal Simek <michal.simek@xxxxxxxxxx> >>> Acked-by: Alan Tull <atull@xxxxxxxxxx> >>> Cc: Sören Brinkmann <soren.brinkmann@xxxxxxxxxx> >>> Cc: linux-kernel@xxxxxxxxxxxxxxx >>> Cc: devicetree@xxxxxxxxxxxxxxx >>> --- >>> >>> Changes from v4: >>> - Ssubject line >>> - Replaced 'or' by 'followed by' as suggested by Rob >>> >>> Changes from v3: >>> - Addressed Michal's comments >>> - Addressed Alan's Comments >>> - Added Alan's Acked-by >>> >>> Changes from v2: >>> - Added refence to generic fpga-region bindings >>> - Fixed up reg property in example >>> - Added fallback to "xlnx,pr-decoupler" without version >>> >>> Changes from v1: >>> - Added clock names & clock to example >>> - Merged some of the description from Michal's version >>> >>> --- >>> .../bindings/fpga/xilinx-pr-decoupler.txt | 36 ++++++++++++++++++++++ >>> 1 file changed, 36 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/fpga/xilinx-pr-decoupler.txt >>> >>> diff --git a/Documentation/devicetree/bindings/fpga/xilinx-pr-decoupler.txt b/Documentation/devicetree/bindings/fpga/xilinx-pr-decoupler.txt >>> new file mode 100644 >>> index 0000000..b2c58fb >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/fpga/xilinx-pr-decoupler.txt >>> @@ -0,0 +1,36 @@ >>> +Xilinx LogiCORE Partial Reconfig Decoupler Softcore >>> + >>> +The Xilinx LogiCORE Partial Reconfig Decoupler manages one or more >>> +decouplers / fpga bridges. >>> +The controller can decouple/disable the bridges which prevents signal >>> +changes from passing through the bridge. The controller can also >>> +couple / enable the bridges which allows traffic to pass through the >>> +bridge normally. >>> + >>> +The Driver supports only MMIO handling. A PR region can have multiple >>> +PR Decouplers which can be handled independently or chained via decouple/ >>> +decouple_status signals. >>> + >>> +Required properties: >>> +- compatible : Should contain "xlnx,pr-decoupler-1.00" followed by >>> + "xlnx,pr-decoupler" >>> +- regs : base address and size for decoupler module >>> +- clocks : input clock to IP >>> +- clock-names : should contain "aclk" >>> + >>> +Optional properties: >>> +- bridge-enable : 0 if driver should disable bridge at startup >>> + 1 if driver should enable bridge at startup >>> + Default is to leave bridge in current state. >> >> Did this get into a common location? If so, then just "see .../?.txt" is >> enough of a description. > > IIRC we went with this as is, with the intent of moving it to > a common location in a separate patch. This binding shows > up in a a few bindings docs, so one patch could move it from all > of them at the same time. That hasn't happened yet. Okay, I'll trust you to do that. Acked-by: Rob Herring <robh@xxxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
