Hi Marcel, On Wed, Apr 12, 2017 at 10:19:21PM +0200, Marcel Holtmann wrote: > Hi Sebastian, > > >>>>>>>> Here is PATCHv3 for the Nokia bluetooth patchset. I addressed all comments from > >>>>>>>> Rob and Pavel regarding the serdev patches and dropped the *.dts patches, since > >>>>>>>> they were queued by Tony. I also changed the patch order, so that the serdev > >>>>>>>> patches come first. All of them have Acked-by from Rob, so I think it makes > >>>>>>>> sense to merge them to serdev subsystem (now) and provide an immutable branch > >>>>>>>> for the bluetooth subsystem. > >>>>>>> > >>>>>>> Greg doesn't read cover letters generally and since the serdev patches > >>>>>>> are Cc rather than To him, he's probably not planning to pick them up. > >>>>>> > >>>>>> I wonder actually if we should merge all of these via bluetooth-next > >>>>>> tree with proper Ack from Greg. However it would be good to also get > >>>>>> buy in from Dave for merging this ultimately through net-next. > >>>>> > >>>>> I don't really care where it goes. I can take the whole thing in my > >>>>> tty/serial tree now if no one objects and I get an ack from the relevant > >>>>> maintainers {hint...} > >>>> > >>>> I think it is better if it goes thru BT tree. I have another driver > >>>> converted that is dependent on this series. There's a couple other > >>>> serdev changes on the list too, but this shouldn't depend on them. > >>> > >>> Is this waiting for something, or could it be queued to > >>> bluetooth-next then? It would be nice to finally have > >>> this in 4.12 :) > >> > >> I would prefer if we can get an ACK from Greg. Then I merge it through the bluetooth-next tree. > > > > Sorry thought this was coming through mine: > > Acked-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> > > > > Merge away! > > so I have applied patches 1-8 to bluetooth-next tree. > > The last 2 I left out since they do cause build issues on non-DT > platforms. We need to be able to build the driver on all platforms > so that sanity compile checks happen all the time. > > CC drivers/bluetooth/hci_nokia.o > drivers/bluetooth/hci_nokia.c:802:34: error: array type has incomplete element type ‘struct of_device_id’ > static const struct of_device_id nokia_bluetooth_of_match[] = { > ^~~~~~~~~~~~~~~~~~~~~~~~ > drivers/bluetooth/hci_nokia.c:803:4: error: field name not in record or union initializer > { .compatible = "nokia,h4p-bluetooth", }, > ^ > drivers/bluetooth/hci_nokia.c:803:4: note: (near initialization for ‘nokia_bluetooth_of_match’) > drivers/bluetooth/hci_nokia.c:815:21: error: implicit declaration of function ‘of_match_ptr’ [-Werror=implicit-function-declaration] > .of_match_table = of_match_ptr(nokia_bluetooth_of_match), > ^~~~~~~~~~~~ > drivers/bluetooth/hci_nokia.c:802:34: warning: ‘nokia_bluetooth_of_match’ defined but not used [-Wunused-variable] > static const struct of_device_id nokia_bluetooth_of_match[] = { > ^~~~~~~~~~~~~~~~~~~~~~~~ Building without CONFIG_OF should work already. Note, that its actually enabled in your build, since nokia_bluetooth_of_match is guarded by "#ifdef CONFIG_OF". The actual problem is, that <linux/of.h> is not included in your build. Looks like it was implicitly included in my configurations, so I didn't notice. I will send PATCHv4 with the added include and includes sorted alphabetically. -- Sebastian
Attachment:
signature.asc
Description: PGP signature