On Tue, Apr 11, 2017 at 11:41 PM, Florian Fainelli <f.fainelli@xxxxxxxxx> wrote: > A subsequent patch is going to make of_match_node() an inline stub when > CONFIG_OF is disabled, which will let the compiler eliminate unused variables. > In order not to clutter the code more, remove the CONFIG_OF #ifdef such that > macb_dt_ids and what it references are always defined. > > Signed-off-by: Florian Fainelli <f.fainelli@xxxxxxxxx> > --- > drivers/net/ethernet/cadence/macb.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/net/ethernet/cadence/macb.c b/drivers/net/ethernet/cadence/macb.c > index 30606b11b128..01016e9525ee 100644 > --- a/drivers/net/ethernet/cadence/macb.c > +++ b/drivers/net/ethernet/cadence/macb.c > @@ -2811,7 +2811,6 @@ static int macb_init(struct platform_device *pdev) > return 0; > } > > -#if defined(CONFIG_OF) > /* 1518 rounded up */ > #define AT91ETHER_MAX_RBUFF_SZ 0x600 > /* max number of receive buffers */ > @@ -3215,7 +3214,6 @@ static const struct of_device_id macb_dt_ids[] = { > { /* sentinel */ } > }; > MODULE_DEVICE_TABLE(of, macb_dt_ids); Did you actually check that the compiler can eliminate things when modules are enabled? Because it's not going to be able to eliminate MODULE_DEVICE_TABLE entry AFAICT. Rob -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html