On Mon, Apr 10, 2017 at 8:32 AM, Viresh Kumar <viresh.kumar@xxxxxxxxxx> wrote: > On 10-04-17, 15:30, Masahiro Yamada wrote: >> 2017-04-10 15:22 GMT+09:00 Viresh Kumar <viresh.kumar@xxxxxxxxxx>: >> > On 10-04-17, 10:46, Viresh Kumar wrote: >> >> Compiling the DT file with W=1, DTC warns like follows: >> >> >> >> Warning (unit_address_vs_reg): Node /opp_table0/opp@1000000000 has a >> >> unit name, but no reg property >> >> >> >> Fix this by replacing '@' with '-' as the OPP nodes will never have a >> >> "reg" property. >> >> >> >> Reported-by: Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx> >> >> Signed-off-by: Viresh Kumar <viresh.kumar@xxxxxxxxxx> >> > >> > + Reported-by: Krzysztof Kozlowski <krzk@xxxxxxxxxx> >> > >> > -- >> > viresh >> >> >> Given that this had already been reported one year before, >> the reported-by credit should be given to Krzysztof. >> >> Please drop my Reported-by. > > I don't think we need to drop any of you. We can very well keep both > :) Yes, keeping both make most sense, I think. Anyway, I found now the original report thread of Masahiro and I see Mark's response about using '-'. In that case I am fine with this. I would prefer to take only the exynos part (separated to ARMv7 and ARMv8) through my tree but I already sent a pull request so I am fine with this going directly to arm-soc. I think you need to update also: Documentation/devicetree/bindings/cpufreq/ti-cpufreq.txt With that change: Reviewed-by: Krzysztof Kozlowski <krzk@xxxxxxxxxx> (and implied acked-by) Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
