Hi Sakari, Thank you for the patch. On Thursday 06 Apr 2017 16:12:08 Sakari Ailus wrote: > media/drv-intf/soc_mediabus.h does depend on struct v4l2_mbus_config which > is defined in media/v4l2-mediabus.h. Include it. > > Signed-off-by: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx> Was this provided indirectly before, through v4l2-of.h perhaps ? If so, shouldn't this patch be moved before 5/8 ? Apart from that, Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> > --- > include/media/drv-intf/soc_mediabus.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/include/media/drv-intf/soc_mediabus.h > b/include/media/drv-intf/soc_mediabus.h index 2ff7737..0449788 100644 > --- a/include/media/drv-intf/soc_mediabus.h > +++ b/include/media/drv-intf/soc_mediabus.h > @@ -14,6 +14,8 @@ > #include <linux/videodev2.h> > #include <linux/v4l2-mediabus.h> > > +#include <media/v4l2-mediabus.h> > + > /** > * enum soc_mbus_packing - data packing types on the media-bus > * @SOC_MBUS_PACKING_NONE: no packing, bit-for-bit transfer to RAM, one -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html