On 04/05/2017 02:36 PM, Alexey Firago wrote: > Hi Geert, > > On 05.04.2017 15:15, Geert Uytterhoeven wrote: >> Hi Alexey, >> >> On Wed, Apr 5, 2017 at 1:46 PM, Alexey Firago >> <alexey_firago@xxxxxxxxxx> wrote: >>> Introduce vc5_chip_info structure to describe features of a particular >>> VC5 chip (id, number of FODs, number of outputs, flags). >>> For now flags are only used to indicate if chip has internal XTAL. >>> vc5_chip_info is set on probe from the matched of_device_id->data. >>> >>> Also add defines to specify maximum number of FODs and clock outputs >>> supported by the driver. >>> >>> With these changes it should be easier to extend driver to support >>> more VC5 models. >>> >>> Signed-off-by: Alexey Firago <alexey_firago@xxxxxxxxxx> >> >> Thanks for your patch! >> >> Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> >> >>> --- a/drivers/clk/clk-versaclock5.c >>> +++ b/drivers/clk/clk-versaclock5.c >>> @@ -113,12 +113,30 @@ >>> #define VC5_MUX_IN_XIN BIT(0) >>> #define VC5_MUX_IN_CLKIN BIT(1) >>> >>> +/* Maximum number of clk_out supported by this driver */ >>> +#define VC5_MAX_CLK_OUT_NUM 3 >>> + >>> +/* Maximum number of FODs supported by this driver */ >>> +#define VC5_MAX_FOD_NUM 2 >>> + >>> +/* flags to describe chip features */ >>> +/* chip has built-in oscilator */ >>> +#define VC5_HAS_INTERNAL_XTAL BIT(0) >> >> VC5_HAS_INTERNAL_OSC? > > I'm fine with renaming it, but shouldn't it be consistent with the rest > of the driver (see "internal-xtal", VC5_XTAL*, etc) and IDT datasheet? > Do you have one with internal ring oscillator or with internal xtal ? The one I had has internal xtal according to the datasheet. -- Best regards, Marek Vasut -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
