Hi Laurent, On Fri, Mar 31, 2017 at 11:21 AM, Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote: > On Fri, Mar 31, 2017 at 11:19 AM, Laurent Pinchart > <laurent.pinchart@xxxxxxxxxxxxxxxx> wrote: >> On Monday 27 Mar 2017 13:05:48 Geert Uytterhoeven wrote: >>> On Mon, Mar 27, 2017 at 11:56 AM, Laurent Pinchart wrote: >>> > The property is used by the driver but is missing from the DT bindings. >>> > Document it. >>> > >>> > Reported-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> >>> > Signed-off-by: Laurent Pinchart >>> > <laurent.pinchart+renesas@xxxxxxxxxxxxxxxx> >>> > --- >>> > Documentation/devicetree/bindings/display/renesas,du.txt | 5 +++++ >>> > 1 file changed, 5 insertions(+) >>> > >>> > diff --git a/Documentation/devicetree/bindings/display/renesas,du.txt >>> > b/Documentation/devicetree/bindings/display/renesas,du.txt index >>> > 1a02f099a0ff..cf34893a1b53 100644 >>> > --- a/Documentation/devicetree/bindings/display/renesas,du.txt >>> > +++ b/Documentation/devicetree/bindings/display/renesas,du.txt >>> > >>> > @@ -36,6 +36,11 @@ Required Properties: >>> > When supplied they must be named "dclkin.x" with "x" being the >>> > input >>> > clock numerical index. >>> > >>> > +Optional Properties: >>> > + >>> > + - vsps: A list of phandles to the VSP nodes that handle the memory >>> > + interfaces for the DU channels (Gen3 only). >>> >>> ", one per channel"? >>> >>> Required for Gen3, optional for Gen2? (cfr. Sergei's patches). >> >> How about making it mandatory on Gen2 as well ? The VSPs are there, even if >> the driver doesn't use them, it makes sense to describe the connection. Of > > Fine for me, as this is hardware description. > >> course the driver will treat the property as optional for backward >> compatibility. > > OK. Will you do this as an incremental update? I noticed the initial version is now in drm-next. Thanks! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html