Hi Enric, On 2017년 03월 02일 16:29, Chanwoo Choi wrote: > Hi, > > On 2017년 03월 01일 20:19, Enric Balletbo i Serra wrote: >> From: Benson Leung <bleung@xxxxxxxxxxxx> >> >> This is the driver for the USB Type C cable detection mechanism >> built into the ChromeOS Embedded Controller on systems that >> have USB Type-C ports. >> >> At present, this allows for the presence of display out, but in >> future, it may also be used to notify host and device type cables >> and the presence of power. >> >> Signed-off-by: Benson Leung <bleung@xxxxxxxxxxxx> >> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@xxxxxxxxxxxxx> >> --- >> Changes since v1: >> Requested by Chanwoo Choi >> - Rename files changing _ for - >> - Remove the unneeded blank line on bottom of header. >> - Remove kobject.h and cros_ec_commands.h includes. >> - Remove the debug message as is not necessary. >> - Use the tab for indentation instead of space for if sentence. >> - Define each variable on different lines when the variables should be >> initialized. >> - Remove EXTCON_USB and EXTCON_USB_HOST as are not really used for now. >> - Add one blank line to split out between state and property setting. >> - Add the author information (header and module) >> >> Enric Balletbo >> - As Rob suggested to rename the compatible name to something indicating that >> is USB Type C related I also renamed the file names, extcon-cros-ec -> >> extcon-usbc-cros-ec, I think it's more clear. >> >> drivers/extcon/Kconfig | 7 + >> drivers/extcon/Makefile | 1 + >> drivers/extcon/extcon-usbc-cros-ec.c | 415 +++++++++++++++++++++++++++++++++++ >> include/linux/mfd/cros_ec_commands.h | 75 +++++++ >> 4 files changed, 498 insertions(+) >> create mode 100644 drivers/extcon/extcon-usbc-cros-ec.c >> > > Looks good to me. > Acked-by: Chanwoo Choi <cw00.chio@xxxxxxxxxxx> > > I think this patch should be handled with patches[1]. > [1] https://lkml.org/lkml/2017/2/14/655 > > I think that one maintainer among following subsystems > (mfd, chrome h/w platform, rtc and extcon) > will apply their git repository, and then one maintainer > will send the pull request of immutable branch for these patches. > As I mentioned, these patch should be handled with related patches[1]. [1] https://lkml.org/lkml/2017/2/14/655 So, I can't apply these patch on extcon git because there is a merge conflict and we should handle these patches with immutable branch between subsystem maintainer. The v4.11-rc5 was released, if you want to apply this patch to the v4.12-rc1, please take care of these patches. -- Best Regards, Chanwoo Choi Samsung Electronics -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
