Hello Lee, On 04/04/2017 04:27 AM, Lee Jones wrote: > On Mon, 03 Apr 2017, Javier Martinez Canillas wrote: > >> Hello Lee, >> >> On 04/03/2017 07:15 AM, Lee Jones wrote: >> >> [snip] >> >>>> + >>>> +The TP61050/TPS61052 is a high-power "white LED driver". This boost converter >>>> +is also used for other things than white LEDs, and also contains a GPIO pin. >>> >>> What functions does it offer? >>> >> >> Same comment than before, I'm not really familiar with this driver. But I'll >> look what are the MFD cell instantiated to better understand dev functions >> and expand this documentation accordingly. > > Writing documentation for H/W you are unfamiliar with is a bad idea IMHO. > I just wanted to add an OF device ID table to the driver to make sure the driver won't have a regression when the I2C core reports an OF modalias but was asked to also write a DT binding doc in this case... I'm happy to drop the DT binding doc patch and someone more familiar to do it as a follow up. Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html