On Sat, 01 Apr 2017, Javier Martinez Canillas wrote: > The driver doesn't have a struct of_device_id table but supported devices > are registered via Device Trees. This is working on the assumption that a > I2C device registered via OF will always match a legacy I2C device ID and > that the MODALIAS reported will always be of the form i2c:<device>. > > But this could change in the future so the correct approach is to have a > OF device ID table if the devices are registered via OF. > > Signed-off-by: Javier Martinez Canillas <javier@xxxxxxxxxxxxxxx> > > --- > > Changes in v3: > - Add a vendor prefix to the compatible string (Rob Herring). > > Changes in v2: > - Don't use of_match_ptr() to avoid build warning when CONFIG_OF is disabled. > > drivers/mfd/retu-mfd.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/drivers/mfd/retu-mfd.c b/drivers/mfd/retu-mfd.c > index d4c114abeb75..937a1c21eec4 100644 > --- a/drivers/mfd/retu-mfd.c > +++ b/drivers/mfd/retu-mfd.c > @@ -308,9 +308,17 @@ static const struct i2c_device_id retu_id[] = { > }; > MODULE_DEVICE_TABLE(i2c, retu_id); > > +static const struct of_device_id retu_of_match[] = { > + { .compatible = "nokia,retu-mfd" }, > + { .compatible = "nokia,tahvo-mfd" }, Please drop the "-mfd". > + { } > +}; > +MODULE_DEVICE_TABLE(of, retu_of_match); > + > static struct i2c_driver retu_driver = { > .driver = { > .name = "retu-mfd", > + .of_match_table = retu_of_match, > }, > .probe = retu_probe, > .remove = retu_remove, -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html