Stefen, On Sun, Mar 12, 2017 at 10:11:01PM +0000, Stefan Wahren wrote: > Use the new function of_property_read_s32_array() to prepare > of-thermal for negative coefficients. These are used by > the upcoming bcm2835_thermal driver. > > Signed-off-by: Stefan Wahren <stefan.wahren@xxxxxxxx> Once done with the comment pointed by Frank, you can add my Reviewed-by: Eduardo Valentin <edubezval@xxxxxxxxx> > --- > drivers/thermal/of-thermal.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/thermal/of-thermal.c b/drivers/thermal/of-thermal.c > index d04ec3b..491d58a 100644 > --- a/drivers/thermal/of-thermal.c > +++ b/drivers/thermal/of-thermal.c > @@ -821,7 +821,8 @@ __init *thermal_of_build_thermal_zone(struct device_node *np) > struct device_node *child = NULL, *gchild; > struct __thermal_zone *tz; > int ret, i; > - u32 prop, coef[2]; > + u32 prop; > + s32 coef[2]; > > if (!np) { > pr_err("no thermal zone np\n"); > @@ -851,7 +852,7 @@ __init *thermal_of_build_thermal_zone(struct device_node *np) > * one sensor per thermal zone. Thus, we are considering > * only the first two values as slope and offset. > */ > - ret = of_property_read_u32_array(np, "coefficients", coef, 2); > + ret = of_property_read_s32_array(np, "coefficients", coef, 2); > if (ret == 0) { > tz->slope = coef[0]; > tz->offset = coef[1]; > -- > 1.7.9.5 > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html