On Mon, Mar 27, 2017 at 8:23 AM, Nandor Han <nandor.han@xxxxxx> wrote: > Add the XRA1403 DTS binding documentation. > > Signed-off-by: Nandor Han <nandor.han@xxxxxx> There is no big problem with this but: > +The XRA1403 is an 16-bit GPIO expander with an SPI interface. Features available: > + - Individually programmable inputs: > + - Internal pull-up resistors > + - Polarity inversion > + - Individual interrupt enable > + - Rising edge and/or Falling edge interrupt > + - Input filter Since you mention that it has interrupts maybe you want to add bindings for the cascaded interrupt and the interrupt-controller; keyword etc already now. We just document what the hardware can do, we don't have to do all of it in the first Linux driver submission. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
