Hi Geert,
Thank you for the patch. It's nice to see DT support for the RSPI driver.
On Tuesday 24 December 2013 12:56:48 Geert Uytterhoeven wrote:
> Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxxxxxxx>
> Cc: devicetree@xxxxxxxxxxxxxxx
> ---
> Documentation/devicetree/bindings/spi/spi-rspi.txt | 27 +++++++++++++++++
> 1 file changed, 27 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/spi/spi-rspi.txt
>
> diff --git a/Documentation/devicetree/bindings/spi/spi-rspi.txt
> b/Documentation/devicetree/bindings/spi/spi-rspi.txt new file mode 100644
> index 000000000000..06ec17fce4c6
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/spi/spi-rspi.txt
> @@ -0,0 +1,27 @@
> +Device tree configuration for Renesas RSPI/QSPI driver
> +
> +Required properties:
> +- compatible : "renesas,rspi-<soctype>". "renesas,rspi-rz" as
> fallback,
> + or
> + "renesas,qspi-<soctype>", "renesas,qspi-rcar" as
> fallback.
I think you need to be a bit more verbose here and explain when to use rspi
and when to use qspi. I'm also wondering where we need the -rz and -rcar
suffixes for the generic compatible strings.
> +- reg : address start and address range size of device
> +- interrupts : 3 interrupts for RSPI (SPEI, SPRI, SPTI),
> + 1 interrupt for QSPI
> +- num-cs : Number of chip selects
> +- #address-cells : should be <1>
> +- #size-cells : should be <0>
I would say "must" instead of "should".
> +
> +Pinctrl properties might be needed, too. See there.
> +
> +Example:
> +
> + spi0: spi@e800c800 {
> + compatible = "renesas,rspi-r7s72100", "renesas,rspi-rz";
> + reg = <0xe800c800 0x24>;
> + interrupts = <0 238 IRQ_TYPE_LEVEL_HIGH>,
> + <0 239 IRQ_TYPE_LEVEL_HIGH>,
> + <0 240 IRQ_TYPE_LEVEL_HIGH>;
You're missing the interrupt-parent property.
Now that we have two ways to specify interrupts (interrupt-parent + interrupts
or interrupts-extended) we should probably decide on a common wording for
interrupt properties in individual DT bindings, but that's out of scope of
this patch.
> + num-cs = <1>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> + };
--
Regards,
Laurent Pinchart
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
