On Fri, 24 Mar 2017 15:35:05 +0100 Andrew Lunn <andrew@xxxxxxx> wrote: > > + pwm_fan { > > /* SUNON HA4010V4-0000-C99 */ > > - compatible = "gpio-fan"; > > - gpios = <&gpio0 24 0>; > > > > - gpio-fan,speed-map = <0 0 > > - 4500 1>; > > + compatible = "pwm-fan"; > > + pwms = <&gpio0 24 4000 0>; > > Hi Ralph > > I believe this last 0 is the flags parameter. Now that we have > #pwm-cells = 1, i think this last 0 should be dropped. > > Andrew Hi Andrew, isn't the 4000 (period?) pwm-cell #2 and 0 (flags?) pwm-cell #3? I actually expect "pwms = <&gpio0 24>;" here or "#pwm-cells = <2>;" Ralph -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html