> + if (val < state->duty_cycle) > + state->period = 1; > + else { > + val -= state->duty_cycle; > + if (val > UINT_MAX) > + state->period = UINT_MAX; > + else if (val) > + state->period = val; > + else > + state->period = 1; > + } Hi Ralph The coding style guide says that if one side of an if else clause has {}, the other side must as well, even if it is a single statement. Andrew -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html