On Fri, Mar 24, 2017 at 02:02:38PM +0530, Jagan Teki wrote:
> On Fri, Mar 24, 2017 at 10:53 AM, Shawn Guo <shawnguo@xxxxxxxxxx> wrote:
> > On Wed, Mar 22, 2017 at 11:18:12PM +0530, Jagan Teki wrote:
> >> From: Jagan Teki <jagan@xxxxxxxxxxxxxxxxxxxx>
> >>
> >> Add support for Sound card and related codec(via i2c1) nodes
> >> on Engicam Is.IoT MX6UL variant module boards.
> >>
> >> Cc: Shawn Guo <shawnguo@xxxxxxxxxx>
> >> Cc: Matteo Lisi <matteo.lisi@xxxxxxxxxxx>
> >> Cc: Michael Trimarchi <michael@xxxxxxxxxxxxxxxxxxxx>
> >> Signed-off-by: Jagan Teki <jagan@xxxxxxxxxxxxxxxxxxxx>
> >> ---
> >> arch/arm/boot/dts/imx6ul-isiot-common.dtsi | 11 +++++++++++
> >> arch/arm/boot/dts/imx6ul-isiot.dtsi | 30 ++++++++++++++++++++++++++++++
> >> 2 files changed, 41 insertions(+)
> >>
> >> diff --git a/arch/arm/boot/dts/imx6ul-isiot-common.dtsi b/arch/arm/boot/dts/imx6ul-isiot-common.dtsi
> >> index b149b5e..c79fa42 100644
> >> --- a/arch/arm/boot/dts/imx6ul-isiot-common.dtsi
> >> +++ b/arch/arm/boot/dts/imx6ul-isiot-common.dtsi
> >> @@ -41,6 +41,17 @@
> >> */
> >>
> >> &i2c1 {
> >> + codec: sgtl5000@0a {
> >
> > sgtl5000: codec@a {
>
> Just to understand, why codec: sgtl5000@0a not a suitable notation?
> couldn't see any Documentation.
The node name should be generic. Please see ePAPR '2.2.2 Generic Names
Recommendation'. Also, the unit-address shouldn't have leading zeros.
Shawn
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
