On Tue, Dec 24, 2013 at 10:34:28AM +0800, Wenyou Yang wrote: > Signed-off-by: Wenyou Yang <wenyou.yang@xxxxxxxxx> I've applied this, however there is one small issue which I seem to have forgotten to point out previously: > + /* Finally register devices */ > + for (i = 0; i < pdata->num_regulators; i++) { The driver should register all regulators regardless of how many are used in the system in order to aid diagnostics. Please send an incremental patch to fix this. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html