On Wed, Mar 22, 2017 at 11:44:21AM -0700, Dmitry Torokhov wrote: > On Thu, Mar 23, 2017 at 12:05:17AM +0530, Jagan Teki wrote: > > On Thu, Mar 23, 2017 at 12:00 AM, Dmitry Torokhov > > <dmitry.torokhov@xxxxxxxxx> wrote: > > > On Wed, Mar 22, 2017 at 04:36:46PM +0530, Jagan Teki wrote: > > >> From: Jagan Teki <jagan@xxxxxxxxxxxxxxxxxxxx> > > >> > > >> Added missing of_match_table for max11801_ts driver with > > >> compatible as "maxim,max11801_ts" > > >> > > > > > > Why not "maxim,max11801"? Also, I think we'd need a binding document. > > > > Compatibility purpose to make this is for touchscreen and few of other > > Compatibility with what? The i2c id is "max11801" (without the "-ts"). Now that I looked at your 2/3 and 3/3 patches you use: +&i2c1 { + max11801: touchscreen@48 { + compatible = "maxim,max11801"; + reg = <0x48>; + interrupt-parent = <&gpio3>; + interrupts = <31 2>; + }; +}; so the compatible you are adding to the driver is definitely wrong. By the way, it would be nice if you used symbolic constants to express interrupt trigger type. Thanks. -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html