> +static int > +core_read_mmd_indirect(struct mt7530_priv *priv, int prtad, int devad) > +{ > + struct mii_bus *bus = priv->bus; > + int value, ret; > + > + /* Write the desired MMD Devad */ > + ret = bus->write(bus, 0, MII_MMD_CTRL, devad); > + if (ret < 0) > + goto err; > + > + /* Write the desired MMD register address */ > + ret = bus->write(bus, 0, MII_MMD_DATA, prtad); > + if (ret < 0) > + goto err; > + > + /* Select the Function : DATA with no post increment */ > + ret = bus->write(bus, 0, MII_MMD_CTRL, (devad | MII_MMD_CTRL_NOINCR)); > + if (ret < 0) > + goto err; Hi Sean This appear to be a copy of mmd_phy_indirect(). There are patches from Russell King which made this a public function. Once Russell patches make net-next, it would be nice to use mmd_phy_indirect(). But that might be as a follow up patch, rather than now, depending on the order of acceptance of the patches. Andrew -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html