Hi! > @@ -47,10 +48,13 @@ static void ttyport_write_wakeup(struct tty_port *port) > struct serport *serport = serdev_controller_get_drvdata(ctrl); > > if (!test_and_clear_bit(TTY_DO_WRITE_WAKEUP, &port->tty->flags)) > - return; > + goto out; > > if (test_bit(SERPORT_ACTIVE, &serport->flags)) > serdev_controller_write_wakeup(ctrl); > + > +out: I'd do "if (test_and_clear_bit() && test_bit()) serdev_()" here. Otherwise it looks fine. Acked-by: Pavel Machek <pavel@xxxxxx> Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Attachment:
signature.asc
Description: Digital signature
