On Sat, 18 Mar 2017, Anatolij Gustschin wrote:
Hi Matthew,
Hi Anatolij,
Thanks for all the feedback. I will create another patch set
incorporating your suggestions.
On Fri, 10 Mar 2017 11:40:27 -0800
matthew.gerlach@xxxxxxxxxxxxxxx matthew.gerlach@xxxxxxxxxxxxxxx wrote:
...
+#include "altera-pr-ip-core.h"
Shouldn't we put this header to include/linux? Compiling the
out-of-tree modules using alt_pr_register/alt_pr_unregister
will not work if this header is in drivers/fpga.
I was not sure if someone would want to access these functions outside of
drivers/fpga. I think it does make sense to move it to
include/linux/fpga.
...
+
+module_platform_driver(alt_pr_platform_driver);
Please add MODULE_LICENSE("GPL v2") here. Otherwise, when built as
a module it cannot be loaded because the alt_pr register/unregister
functions are exported as GPL only. Also please add module author
and description.
Got it. Thanks!
Thanks,
Anatolij
--
To unsubscribe from this list: send the line "unsubscribe linux-fpga" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
