Mostly good, one nitpick: On 16/03/2017 at 13:51:08 -0400, Chris Brandt wrote: > res = platform_get_resource(pdev, IORESOURCE_IO, 0); > + if (res == NULL) if (!res) is preferred here -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html