Re: [PATCH 1/5] rtc: rtc-sh: add support for rza series

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




Hi Chris,

On Thu, Mar 16, 2017 at 6:51 PM, Chris Brandt <chris.brandt@xxxxxxxxxxx> wrote:
> This same RTC is used in RZ/A series MPUs, therefore with some slight
> changes, this driver can be reused. Additionally, since ARM architectures
> require Device Tree configurations, device tree support has been added.

Thanks for your patch!

> Signed-off-by: Chris Brandt <chris.brandt@xxxxxxxxxxx>

Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>

> --- a/drivers/rtc/Kconfig
> +++ b/drivers/rtc/Kconfig
> @@ -1303,10 +1303,10 @@ config RTC_DRV_SA1100
>
>  config RTC_DRV_SH
>         tristate "SuperH On-Chip RTC"
> -       depends on SUPERH && HAVE_CLK
> +       depends on (SUPERH || ARCH_RENESAS) && HAVE_CLK

I believe the dependency on HAVE_CLK is not needed.
SuperH selects CLKDEV_LOOKUP, which selects HAVE_CLK.
ARM (and ARM64) selects COMMON_CLK, which selects HAVE_CLK.

interestingly, SuperH already did so at the time the dependency was added...

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]
  Powered by Linux