Thanks Sachin,
On 9 December 2013 11:53, Sachin Kamat <sachin.kamat@xxxxxxxxxx> wrote:
> Hi Rahul,
>
> On 6 December 2013 21:26, Rahul Sharma <rahul.sharma@xxxxxxxxxxx> wrote:
>> From: Pankaj Dubey <pankaj.dubey@xxxxxxxxxxx>
>>
>> This patch add basic arch side support for exynos5260 SoC.
>>
>> Signed-off-by: Pankaj Dubey <pankaj.dubey@xxxxxxxxxxx>
>> Signed-off-by: Arun Kumar K <arun.kk@xxxxxxxxxxx>
>
> Since you are posting the patch, your signed off is also required.
Right. I will add my Sign off.
>
> [snip]
>
>> void exynos4_restart(enum reboot_mode mode, const char *cmd)
>> {
>> __raw_writel(0x1, S5P_SWRESET);
>> @@ -371,7 +387,8 @@ static void __init exynos4_map_io(void)
>> static void __init exynos5_map_io(void)
>> {
>> iotable_init(exynos5_iodesc, ARRAY_SIZE(exynos5_iodesc));
>> -
>> + if (soc_is_exynos5260())
>> + iotable_init(exynos5260_iodesc, ARRAY_SIZE(exynos5260_iodesc));
>
> Add this after 5250 to maintain numerical order.
ok.
>
>> if (soc_is_exynos5250())
>> iotable_init(exynos5250_iodesc, ARRAY_SIZE(exynos5250_iodesc));
>> }
>
> [snip]
>>
>> #define S5P_VA_SYSRAM S3C_ADDR(0x02400000)
>> #define S5P_VA_SYSRAM_NS S3C_ADDR(0x02410000)
>> +
> Unnecessary blank line addition.
I will remove this.
Regards,
Rahul Sharma.
>
>
> --
> With warm regards,
> Sachin
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
