Re: [PATCH v2 00/17] Move firmware specific code to firmware specific locations

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On Mon, Mar 13, 2017 at 11:27:40PM +0100, Rafael J. Wysocki wrote:
> On Monday, March 06, 2017 05:42:46 PM Sakari Ailus wrote:
> > Hi, 
> > 
> > This set moves firmware specific implementations of the device / fwnode
> > property API to locations that are specific to firmware implementation,
> > still leaving property set (which isn't really firmware) implementation in
> > drivers/base/property.c.
> > 
> > The set depends on the ACPI graph support v4 patches I posted a moment
> > ago.
> > 
> > The patches may be found with dependencies here:
> > 
> > <URL:https://git.linuxtv.org/sailus/media_tree.git/log/?h=acpi-graph-cleaned>
> > 
> > since v1:
> > 
> > - Move the three bugfixes in front of the set into a separate patchset.
> >   There are no dependencies to those from the rest of the patches.
> > 
> > - Rebase on current ACPI graph support patches (themselves on PM tree
> >   4.11-rc1 merge).
> 
> To me, all material from patches [1-11/17] can easily go into one patch which
> would also help to review it quite a bit.
> 
> Analogously, all material in patches [12-16/17] can go into one patch too.
> 
> The split as is appears quite artificial, honestly.

I believe it's easier to review the way it is. Each patch is simple and it's
easy to see where a particular piece of code is moved. I'm happy to fold
them, too, but I'd prefer keep "[PATCH v2 07/17] device property: Read
strings using string array reading functions" separate, as it changes the
implementation of reading single strings.

How about that?

-- 
Regards,

Sakari Ailus
e-mail: sakari.ailus@xxxxxx	XMPP: sailus@xxxxxxxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]
  Powered by Linux