On Tue, Mar 14, 2017 at 3:03 PM, Bartlomiej Zolnierkiewicz <b.zolnierkie@xxxxxxxxxxx> wrote: > > Hi, > > On Saturday, March 11, 2017 07:25:22 PM Krzysztof Kozlowski wrote: >> The Exynos4412 has the same watchdog as newer SoCs (e.g. Exynos5250). >> Just like the others, for working it requires additional steps in Power >> Management Unit: unmasking the reset request and enabling the system >> reset. Without these additional steps in PMU, the watchdog will not be >> able to reset the system on expiration event. >> >> Change the compatible of Exynos4412 watchdog device node to >> samsung,exynos5250-wdt which includes the additional PMU steps. > > This is going to confuse people. How's about doing it cleanly > (by adding samsung,exynos4412-wdt compatible and convert existing > users to use instead)? I don't find usage of 5250 in Exynos4412 DTS as confusing because since long time I do not threat these numbers as having any meaning (e.g. 3250 is newer...). Yes, we can duplicate the compatible for that purpose. Care to send a patch for this? Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html