Hi Linus, On 03/14/2017 09:23 AM, Linus Walleij wrote: > On Wed, Feb 22, 2017 at 5:56 PM, Sebastien Bourdelin > <sebastien.bourdelin@xxxxxxxxxxxxxxxxxxxx> wrote: >> On 02/04/2017 05:14 AM, Linus Walleij wrote: > >>>> + gpiod_set_array_value_cansleep(gpios->ndescs, gpios->desc, values); >>> >>> This can also fail and you should check the return code and print an error >>> message if it does. >>> >> As far as i understood, the "gpiod_set_array_value_cansleep(...)" >> function doesn't return >> anything, it will return immediately if gpios->desc is null but nothing >> else. >> Did i miss something? > > No I did, sorry about that. > > We *should* make these functions return errors but currently they do not. > Ok got it. Thanks! >>> Error codes? >>> >> Same question here, these functions only make call to >> "gpiod_set_value_cansleep(...)", >> which as far as i understood doesn't return any error code. > > Yeah, forget that. > Ok. >>>> + gpiod_set_value_cansleep(ts_nbus->csn, 1); >>> >>> Here too. >>> >> Same question, doesn't seem to have an error code. > > That too. > Ok. > Yours, > Linus Walleij > Best regards, Sebastien Bourdelin. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
