Re: [PATCH 1/2] ARM: dts: BCM5301X: Specify serial console parameters

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




> >The alias is fine. But putting the stdout-path here is unusual. Which
> >serial port is used for console is board specific, where as
> >bcm5301x.dtsi is very generic, it describes the SoC, not a board.  If
> >you look at other .dtsi files, those that specify stdout-path contain
> >properties which are common to a range of similar boards.
> 
> So far I've never seen any board using other uart. Also uart0 is disabled by
> default and we enable it per board family (BCM4708 / BCM47081 / BCM4709 /
> BCM47094). I think it's just more practical to have simple DTS that covers
> 99,9% boards by default and handled that margin of devices separately.
> 
> We already got a lot of duplicated code for enabling uart0, see:
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=7b790d3b2943bf8e7e7bafe184008bd6451fe0bd
> 
> Jon Mason from Broadcom who knows this hardware and designs very well confirmed
> it's a sane/safe assumption.

I don't disagree with you, it does make sense. But it is just
different to every other SoC .dtsi file Linux has. And we try to avoid
things being different.

It is down to Florian to decide, as maintainer.

   Andrew
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]
  Powered by Linux