2017-03-13 17:53 GMT+01:00 Sergei Shtylyov <sergei.shtylyov@xxxxxxxxxxxxxxxxxx>: > Hello! > > On 03/13/2017 07:36 PM, Bartosz Golaszewski wrote: > >> Add DT bindings for the onboard SATA controller present on the DM816x >> SoCs. >> >> Signed-off-by: Bartosz Golaszewski <bgolaszewski@xxxxxxxxxxxx> >> --- >> Documentation/devicetree/bindings/ata/ahci-dm816.txt | 20 >> ++++++++++++++++++++ >> 1 file changed, 20 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/ata/ahci-dm816.txt >> >> diff --git a/Documentation/devicetree/bindings/ata/ahci-dm816.txt >> b/Documentation/devicetree/bindings/ata/ahci-dm816.txt >> new file mode 100644 >> index 0000000..b87ed5a >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/ata/ahci-dm816.txt >> @@ -0,0 +1,20 @@ >> +Device tree binding for the TI DM816 AHCI SATA Controller >> +--------------------------------------------------------- >> + >> +Required properties: >> + - compatible: must be "ti,dm816-ahci" >> + - reg: physical base address and size of the register region used by >> + the controller (as defined by the AHCI 1.1 standard) >> + - interrupts: interrupt specifier (refer to the interrupt binding) >> + - clocks: clock specifiers (refer to the clock binding); two clocks > > > There should be a phandle preceding the clock specifier, all new such > props are different to the old "interrupts" (which had phandle in a separate > "interrupt-parent" prop). > I'm afraid I don't understand - could you point me to an example? >> + must be specified: the functional clock and an external >> + reference clock >> + >> +Example: >> + >> + sata: sata@4a140000 { >> + compatible = "ti,dm816-ahci"; >> + reg = <0x4a140000 0xffff>; > > > I think you meant 0x10000 ISO 0xffff -- this is a size, not limit. > Right, thanks. >> + interrupts = <16>; >> + clocks = <&sysclk5_ck>, <&sata_refclk>; >> + }; >> > > MBR, Sergei > Thanks, Bartosz Golaszewski -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html