Hi Rahul, On Friday 20 of December 2013 18:27:25 Rahul Sharma wrote: > DT nodes contain clock numbers which are referred by drivers > to get the clocks. These numbers are replaced by MACROs > which are defined in the exynos5420-clk.h header file. This is a good idea, but we already have such conversion scheduled for all the existing clock drivers in an automated way. Andrzej Hajda (on CC) has a script that automatically converts DTS files and clock drivers from enums to defines. Also such change needs to be done in a timely manner, due to greatly increasing chance of conflicting other patches. My suggestion is to drop this and patch 3/3 from this series and let us handle this using Andrzej's script at appropriate point of time. > > Signed-off-by: Rahul Sharma <rahul.sharma@xxxxxxxxxxx> > --- > arch/arm/boot/dts/exynos5420.dtsi | 47 +++++++++++++++++++------------------ > 1 file changed, 24 insertions(+), 23 deletions(-) > > diff --git a/arch/arm/boot/dts/exynos5420.dtsi b/arch/arm/boot/dts/exynos5420.dtsi > index e552608..db8b2da 100644 > --- a/arch/arm/boot/dts/exynos5420.dtsi > +++ b/arch/arm/boot/dts/exynos5420.dtsi > @@ -17,6 +17,7 @@ > #include "exynos5420-pinctrl.dtsi" > > #include <dt-bindings/clk/exynos-audss-clk.h> > +#include <dt-bindings/clk/exynos5420-clk.h> By the way, this header is added in patch 3/3, so this patch breaks bisectability, which is not acceptable. Best regards, Tomasz -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
